Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple download bug #77

Merged
merged 12 commits into from
Apr 21, 2020
Merged

Fix multiple download bug #77

merged 12 commits into from
Apr 21, 2020

Conversation

pravinyo
Copy link
Owner

Following fixes are been included in this PR:

  • Download Multiple file
  • UI not showing status
  • Progress bar bug
  • Download Progress bug for file already downloaded
  • File redownload bug

Following issues are tagged for resolution:
issue #52
issue #53

@pravinyo
error handling added and string formatting replace for timber
dccbe7e
@pravinyo
string formatting replace for timber
767639e
@pravinyo
log message formatted
b54ee0f
@pravinyo
method renamed to reflex it's function
6948b78
@pravinyo
bug fixed: return previous downloadId instead of -99 value.
a3ad1a4
@pravinyo
observer bug fixed: for already downloaded file skip and call updateD…
c1a703b 
…ownloaded method.
@pravinyo
bug fix: url values was wrongly checked with name column, now fixed
9629949
@pravinyo
DownloadStatus.java class added for status code
248b6d2
@pravinyo
status code moved to DownloadStatus.java
d9f1447
@pravinyo
Data structure for LocalFileDetails.java added contain details for lo…
5e53661 
…cally downloaded file
@pravinyo
status code imported from DownloaderStatus file and retry logic added…
dd21fc4 
… if downloaded file is missing
@pravinyo
progressbar bug fixed
a708f76
@pravinyo pravinyo self-assigned this Apr 21, 2020
@github-actions github-actions bot added app issues related to app working feature Feature related issue library issues related to core library labels Apr 21, 2020
This was linked to issues Apr 21, 2020
Downloader downloading same file multiple times #52
Closed
UI should show check for downloaded files #53
Closed
@pravinyo pravinyo added this to the bug fixes milestone Apr 21, 2020
@pravinyo pravinyo changed the base branch from release to development April 21, 2020 14:34
@pravinyo pravinyo merged commit 56f735b into development Apr 21, 2020
@pravinyo pravinyo deleted the fix_multiple_download_bug branch April 21, 2020 14:49
@github-actions
Copy link

github-actions bot commented May 2, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pravinyo pravinyo

Labels
app issues related to app working feature Feature related issue library issues related to core library
Projects
None yet
Milestone
bug fixes
Development

Successfully merging this pull request may close these issues.

UI should show check for downloaded files Downloader downloading same file multiple times
1 participant
@pravinyo