Issue 92: Fix ci build failure due to cargo clean bug. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep <sandeep.shridhar@emc.com>
shrids
commented
Apr 27, 2020
| @@ -49,12 +49,6 @@ jobs: | |||
| override: true | |||
| components: rustfmt, clippy | |||
|
|
|||
| - name: Run cargo clean | |||
There was a problem hiding this comment.
removed the redundant clean during cargo check.
shrids
commented
Apr 27, 2020
| @@ -98,12 +92,6 @@ jobs: | |||
| override: true | |||
| components: rustfmt, clippy | |||
|
|
|||
| - name: Run cargo clean | |||
There was a problem hiding this comment.
removed the redundant cargo clean before cargo test
Signed-off-by: Sandeep <sandeep.shridhar@emc.com>
zwx14700
approved these changes
Apr 27, 2020
Tristan1900
approved these changes
Apr 27, 2020
tkaitchuck
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sandeep sandeep.shridhar@emc.com
Change log description
Workaround for cargo clean bug
https://github.com/rust-lang/cargo/issues/8149Purpose of the change
Fixes #92
What the code does
Workaround for cargo clean bug
https://github.com/rust-lang/cargo/issues/8149How to verify it
Builds should work once the changes are present in master branch.