-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package broken with newest opentelemetry dependencies #151
Comments
That's actually great news 😂 I will try to patch that up this weekend, It will require a major version though. I've been keeping track of this release for a while but some packages might be moved somewhere else FYI. |
any news? |
howdy @elbasan there's a WIP Pr coming up to fix that. Unfortunately since metrics API was experimental, there is no |
Hey there, thanks for the quick response. Could you maybe tell me about to which versions i should downgrade the otel libaries so it still works |
@elbasan I need to check again but my current project is running |
I've fixed the compatibility with opentelemetry 0.27 in marcbachmann/opentelemetry-node-metrics#3 For the metrics, it should be straight forward to migrate and even keep the compatibility: https://github.com/marcbachmann/opentelemetry-node-metrics/blob/master/index.js#L9-L16 |
This still seems to be broken:
|
The dependencies got updated on the branch |
@MattGson could you share which packages you are using? (versions) I have it working here https://github.com/pragmaticivan/nestjs-otel-prom-grafana-tempo (latest released version) |
@MattGson Maybe you forgot to do |
The same problem:
package.json:
|
same problem, but if I set |
It works for me, and I have to turn off this switch to use it |
Investigating the changes, be aware that metrics SDK in JS is not stable and this package support for metrics aim to give it as a tease before 1.0. It's unlikely you might get quick support by the underlying packages, so I would slow down a bit on updating packages related to metrics. |
Hello. I am also getting this error:
From what I understood this was fixed here in the @pragmaticivan Any chance to create a new release please? |
For those in a hurry, here is a solution: const OpenTelemetryModuleConfig = OpenTelemetryModule.forRoot({ |
For me, the below worked. It seems to be an issue with the old version(1.1.0) of add the following in btw, I am using npm users: https://stackoverflow.com/questions/15806152/how-do-i-override-nested-npm-dependency-versions @pragmaticivan |
Working example here: https://github.com/pragmaticivan/nestjs-otel-prom-grafana-tempo |
When using the latest opentelementy packages (0.27.0), the Nest application fails to start with the following error:
The text was updated successfully, but these errors were encountered: