Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metrics API to latest Feature-Freeze Spec #2480

Closed
14 tasks done
pragmaticivan opened this issue Sep 17, 2021 · 12 comments
Closed
14 tasks done

Update Metrics API to latest Feature-Freeze Spec #2480

pragmaticivan opened this issue Sep 17, 2021 · 12 comments

Comments

@legendecas
Copy link
Member

legendecas commented Sep 22, 2021

According to the tracking project https://github.com/orgs/open-telemetry/projects/8, implementations of Java and .net are expected to experiment with the new spec before the feature-freeze stage. And Metrics SDK spec is expected to reach feature-freeze at 9/30/2021.

@pragmaticivan
Copy link
Contributor Author

pragmaticivan commented Sep 22, 2021

Would that block development for experimental packages? This was also done in the go package 20 days ago: open-telemetry/opentelemetry-go#2202

Note in this PR:

Note: The OTel-Go metrics API is still considered experimental and subject to change in the future. We discussed making this change ASAP to avoid confusing new users who review the API specification and will not understand these legacy names.

@weyert
Copy link
Contributor

weyert commented Sep 22, 2021

I think the idea was to wait until the SDK spec is finalised based on experience last time were the spec changed quite a bit while working on developing it. Think this time it's decided to wait it's all set in stone before start working on it.

@pragmaticivan But you can always start making a list of difference between current implementation and the draft Metrics SDK :)

@vmarchaud
Copy link
Member

Would that block development for experimental packages

Nothing, you are free to start working on it. As @weyert said we (contributors at the time) invested quit a bit of time to have a initial version at the time which was pretty much out of date as soon as the implementation was done so there was some kind of agreement on waiting stable spec before working on this.

@dyladan
Copy link
Member

dyladan commented Sep 22, 2021

I am pretty sure the spec is settled enough to work on now.

@pirgeo
Copy link
Member

pirgeo commented Oct 5, 2021

These are a few requirements that I think need to be fulfilled in order to meet the specification. Note that these are only API requirements, the SDK changes should be tracked in a separate issue.

* Attributes can have numerical values and arrays of primitive data types as values (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md#attributes)

If there is something I missed, please let me know, and I'll extend the list.

@dyladan
Copy link
Member

dyladan commented Oct 5, 2021

I moved the task list to the main issue up top. @pragmaticivan feel free to edit it as you see fit.

@pragmaticivan
Copy link
Contributor Author

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md is stable 🎉

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@dyladan
Copy link
Member

dyladan commented Jan 31, 2022

@pragmaticivan all items are checked. Can this PR be closed?

/cc @legendecas

@pragmaticivan
Copy link
Contributor Author

@dyladan LGTM!

@legendecas
Copy link
Member

Closing for now. Thank you everyone for making this happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants