Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VariantType to workaround compiler issue #95

Closed
wants to merge 1 commit into from

Conversation

jyapayne
Copy link
Contributor

@jyapayne jyapayne commented May 1, 2021

Workaround for: nim-lang/Nim#16462.

It doesn't hurt to change these since it's an internal enum. This makes this repo work with the latest Nim devel.

@endragor
Copy link
Member

endragor commented May 3, 2021

Thanks for the PR, but the enum is not private - it's re-exported from variants.nim.

And even without that godotinternal module is a part of the public API. It just separates stuff that you should use only when you know what you are doing. But there are useful application use cases for it.

@endragor endragor closed this May 3, 2021
@jyapayne
Copy link
Contributor Author

jyapayne commented May 3, 2021

Ah, I see. Alright, guess it's better to wait for the compiler to be fixed.

@jyapayne jyapayne deleted the change_varianttype branch May 3, 2021 13:19
@jyapayne
Copy link
Contributor Author

jyapayne commented May 3, 2021

@endragor actually, this can be worked around by moving the template below importing of the arrays module. Do you mind if template definePoolArray is moved below import arrays in godot/core/poolarrays.nim?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants