Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hex package #80

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Fix hex package #80

merged 2 commits into from
Jul 6, 2016

Conversation

mschae
Copy link
Contributor

@mschae mschae commented Jul 6, 2016

Hey,

thanks for releasing 1.0, unfortunately I get the following error when using the hex package:

** (exit) an exception was raised:
    ** (UndefinedFunctionError) undefined function :string_lexer.string/1 (module :string_lexer is not available)
        :string_lexer.string('This is an example')
        lib/earmark/helpers/lookahead_helpers.ex:62: Earmark.Helpers.LookaheadHelpers.tokenize/1
        lib/earmark/helpers/lookahead_helpers.ex:19: Earmark.Helpers.LookaheadHelpers.opens_inline_code/1
        lib/earmark/block.ex:508: Earmark.Block.inline_or_text?/2
        lib/earmark/block.ex:342: Earmark.Block._consolidate_para/3
        lib/earmark/block.ex:148: Earmark.Block._parse/3
        lib/earmark/block.ex:60: Earmark.Block.lines_to_blocks/2
        lib/earmark/block.ex:51: Earmark.Block.parse/2
        lib/earmark.ex:204: Earmark.parse/2
        lib/earmark.ex:186: Earmark.to_html/2

The reason is that the src folder is not included in the hex package. This PR fixes that.

Thanks again

@RobertDober RobertDober merged commit 1103a78 into pragdave:master Jul 6, 2016
@RobertDober
Copy link
Collaborator

Great catch Michael, sorry to bother you @pragdave but we need a rerelease here. My bad

@RobertDober
Copy link
Collaborator

As a side note, I guess this is the motivation I needed to create the Earsuite project which shall act as kind of an Acceptance Testing Suite for Earmark. Seems https://github.com/philss/floki should do a great job for structural comparison of the created HTLM against a reference.

@mschae
Copy link
Contributor Author

mschae commented Jul 6, 2016

To close the loop on this, 1.0.1 is published to hex and works fine.

Thanks again everyone!

@mschae mschae deleted the fix-hex-package branch July 6, 2016 21:38
@RobertDober
Copy link
Collaborator

This is great, I completely s*** up and everybody is thanking me :). Thank you and Dave for cleaning up my mess.

@mschae
Copy link
Contributor Author

mschae commented Jul 7, 2016

Ha well you forgot to include one measly folder in the package. Tests didn't flag this. If this is your definition of messing up I envy you. ;)

@RobertDober
Copy link
Collaborator

Well thank you for your kind words. I meant it is just great how OSS works, I completely broke Earmark and it took a kind soul a millisecond to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants