Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Logger.debug #504

Merged

Conversation

alexanderttalvarez
Copy link
Contributor

Hello!

Can we remove the Logger.debug? it's showing all the compiled lists on the logs.

I think it was included here for debugging, but it shouldn't be necessary now.

@alexanderttalvarez
Copy link
Contributor Author

I updated the PR to remove the unused match variable.

@cblavier
Copy link

cblavier commented Dec 18, 2024

Can you please merge it?

Meanwhile, one could suppress logging with the following settings:

config :logger,
  backends: [:console],
  compile_time_purge_matching: [
    [module: Earmark.Parser.LineScanner]
  ]

you then need to recompile your deps

@alexanderttalvarez
Copy link
Contributor Author

@cblavier I can't merge it myself, it has to be the repo's author.

@cblavier
Copy link

I know, I was asking @pragdave to do it :)

@amit-chaudhari1 amit-chaudhari1 merged commit 55c4afb into pragdave:master Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants