changed with syntax, refactored cond -> if/else

pragdave · Jan 9, 2024 · 1c298df · 1c298df
1 parent c1d7f4a
commit 1c298df
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/lib/earmark.ex b/lib/earmark.ex
@@ -260,8 +260,8 @@ defmodule Earmark do
     `iex` usage.
   """
   def version() do
-    with {:ok, version} = :application.get_key(:earmark, :vsn),
-      do: to_string(version)
+    with {:ok, version} <- :application.get_key(:earmark, :vsn),
+         do: to_string(version)
   end
 
   defp _as_ast(lines, options)

diff --git a/lib/earmark_parser.ex b/lib/earmark_parser.ex
@@ -614,7 +614,7 @@ defmodule Earmark.Parser do
   end
 
   def as_ast(_, options) do
-    raise ArgumentError, "#{inspect options} not a legal options map or keyword list"
+    raise ArgumentError, "#{inspect(options)} not a legal options map or keyword list"
   end
 
   defp _as_ast(lines, options) do
@@ -627,8 +627,8 @@ defmodule Earmark.Parser do
     `iex` usage.
   """
   def version() do
-    with {:ok, version} = :application.get_key(:earmark_parser, :vsn),
-      do: to_string(version)
+    with {:ok, version} <- :application.get_key(:earmark_parser, :vsn),
+         do: to_string(version)
   end
 end
 

diff --git a/test/acceptance/earmark/postprocessor/replace_subtree_test.exs b/test/acceptance/earmark/postprocessor/replace_subtree_test.exs
@@ -48,10 +48,12 @@ defmodule Test.Acceptance.Earmark.Postprocessor.ReplaceSubtreeTest do
   defp render_code_node({"code", attrs, _content, meta} = node) do
     classes = Earmark.AstTools.find_att_in_node(node, "class") || ""
 
-    cond do
-      classes =~ "inline" -> node
-      true -> {:replace, {"code", attrs, "xxx", meta}}
+    if classes =~ "inline" do
+      node
+    else
+      {:replace, {"code", attrs, "xxx", meta}}
     end
   end
 end
+
 # SPDX-License-Identifier: Apache-2.0