Fix shell-completion line in release build script

[Marcool04]

Hi there.

While fixing up the Arch User Repo install script (https://aur.archlinux.org/packages/noseyparker) that I maintain for noseyparker today I noticed there is a likely typo in the shell-completion step of the build script.

The script iterates over several shells, but the call to noseyparker shell-completion in there is always done with --shell zsh so the completion files would be identical I imagine.

This pull request is a simple fix for that.

Best regards,

Mark.

[bradlarsen]

Thanks @Marcool04 — yes, that was a mistake!

I didn't know about the Arch package. Thanks for the pointer.

I do try to keep main in good working order, but it is unstable. Unless you are explicitly making a package for the latest commit, it would probably be better to build from the latest Nosey Parker release.

[Marcool04]

Hi @bradlarsen. Yep that's basically what the AUR package is doing. This line: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=noseyparker#n21 pulls the source from the tagged commit that is referenced by $pkgver so right now, 0.16.0. I am packaging the stable releases. Basically all I've done is picked apart your release builder zsh script (in particular removed the mac parts) and put it into the format required by an Arch PKGBUILD.

Regards,

Mark.

[bradlarsen]

@Marcool04 That makes sense — thanks for the clarification.

i see in that PKGBUILD script that there are explicit dependencies on libpcap, sqlite, and ragel, with the note that those are needed for building vectorscan. Is that actually the case on Arch? I went through some effort a couple releases ago to eliminate as many build-time dependencies for that as I could. I thought only cmake and pkgconfig were needed.

[bradlarsen]

The next Nosey Parker release will also include manpages, fyi: #88

[Marcool04]

Oh quite right! I just got them from the vectorscan readme: https://github.com/VectorCamp/vectorscan/blob/develop/README.md?plain=1#L101 but I never checked to see if they were needed.
Apparently not, compiles fine without.
Thanks for the info.