Merge pull request #221 from praekeltfoundation/add-all-language-import

Add empty value on content import form

home/forms.py

@@ -12,7 +12,9 @@ class UploadContentFileForm(UploadFileForm):
     YES_NO = ((False, "No"), (True, "Yes"))
     purge = forms.ChoiceField(choices=YES_NO)
     locale = forms.ModelChoiceField(
-        queryset=Locale.objects.all(), empty_label="Select Locale"
+        queryset=Locale.objects.all(),
+        empty_label="Import all languages",
+        required=False,
     )
 
 

home/tests/test_forms.py

@@ -0,0 +1,29 @@
+import pytest
+from django.core.files.uploadedfile import SimpleUploadedFile
+
+from home.forms import UploadContentFileForm
+
+
+class TestUploadContentFileForm:
+    @pytest.mark.django_db
+    def test_empty_locale_label(self):
+        """
+        The label for the empty locale option should be Import all languages
+        """
+        assert "Import all languages" in UploadContentFileForm().render()
+
+    def test_default_locale(self):
+        """
+        Not supplying a locale should give a default "None" value, which the importer
+        interprets as we should import all locales found in the file
+        """
+        file = SimpleUploadedFile(
+            name="test.csv", content=b"foo,bar", content_type="text/csv"
+        )
+        form = UploadContentFileForm(
+            files={"file": file},
+            data={"file_type": "CSV", "purge": "False", "locale": ""},
+        )
+
+        assert form.errors == {}
+        assert form.cleaned_data["locale"] is None

pyproject.toml

@@ -60,6 +60,7 @@ exclude = [  # Regexes.
     '^home/tests/test_(management|management_related_tag|models)\.py',
     '^home/tests/test_(unique_slug_hook|views|wagtail_hooks)\.py',
     '^home/tests/test_(whatsapp|whatsapp_template_name_migration)\.py',
+    '^home/tests/test_(forms)\.py',
 ]
 files = "."
 follow_imports = "skip"