-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do Not Merge] NetStandard Upgrade: Update NuSpec & Raw NuGets #546
Conversation
Should now install in just about every application
@onovotny can you validate my changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look ok to me
sqlite-net-pcl.nuspec
Outdated
</group> | ||
<group targetFramework="netstandard1.1"> | ||
<dependency id="SQLitePCLRaw.bundle_green" version="1.1.5" /> | ||
<dependency id="NETStandard.Library" version="1.6.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NETStandard.Library 1.6.1 is better since it has fixes for Xamarin related issues with certain PCL profiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good :) yeah I see that is the default now of file new
Also, do you want dependency groups for Xamarin tvOS and watchOS? |
I think this library itself is still actually a PCL which is really odd, I am going to change it over to .NET Standard 1.1 and then add tvos/watchos |
Alright @onovotny I think this should be good now, I have created a new .NET Standard 1.1 project and added in the references needed. I am not sure how this will build on a mac though... I assume it will be alright.... @praeclarum may want to switch over to appveyor for the VS 2017 build |
I think that once Bitrise upgrades to the latest stable it will build up. |
@jamesmontemagno if you're going that approach, you can just use the pack targets too -- |
I have been working on a new version of this that builds using .NET Core on Bitrise. I'm making good progress! Let's switch to there. |
Should now install in just about every application