Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] NetStandard Upgrade: Update NuSpec & Raw NuGets #546

Closed
wants to merge 11 commits into from

Conversation

jamesmontemagno
Copy link
Contributor

Should now install in just about every application

Should now install in just about every application
@jamesmontemagno
Copy link
Contributor Author

@onovotny can you validate my changes here.

Copy link

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look ok to me

</group>
<group targetFramework="netstandard1.1">
<dependency id="SQLitePCLRaw.bundle_green" version="1.1.5" />
<dependency id="NETStandard.Library" version="1.6.0" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NETStandard.Library 1.6.1 is better since it has fixes for Xamarin related issues with certain PCL profiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good :) yeah I see that is the default now of file new

@clairernovotny
Copy link

Also, do you want dependency groups for Xamarin tvOS and watchOS?

@jamesmontemagno jamesmontemagno changed the title Update NuSpec & Raw NuGets [Do Not Merge] Update NuSpec & Raw NuGets May 21, 2017
@jamesmontemagno
Copy link
Contributor Author

I think this library itself is still actually a PCL which is really odd, I am going to change it over to .NET Standard 1.1 and then add tvos/watchos

@jamesmontemagno jamesmontemagno changed the title [Do Not Merge] Update NuSpec & Raw NuGets [Do Not Merge] NetStandard Upgrade: Update NuSpec & Raw NuGets May 21, 2017
@jamesmontemagno
Copy link
Contributor Author

jamesmontemagno commented May 21, 2017

Alright @onovotny I think this should be good now, I have created a new .NET Standard 1.1 project and added in the references needed.

I am not sure how this will build on a mac though... I assume it will be alright.... @praeclarum may want to switch over to appveyor for the VS 2017 build

@jamesmontemagno
Copy link
Contributor Author

I think that once Bitrise upgrades to the latest stable it will build up.

@clairernovotny
Copy link

@jamesmontemagno if you're going that approach, you can just use the pack targets too -- dotnet pack. All of the info in the nuspec have equivalent properties in the csproj. The only reason to really split out the dependency groups as you have them would be to potentially minimize pain on people using packages.config with older project types.

@praeclarum
Copy link
Owner

I have been working on a new version of this that builds using .NET Core on Bitrise.

I'm making good progress! Let's switch to there.

#561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants