-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor js interpreter to be compatible with flipper zero js #750
Draft
Tawank
wants to merge
45
commits into
pr3y:main
Choose a base branch
from
Tawank:js_refractor_require
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65dfa72
to
35443d6
Compare
…ions to js interpreter
…race lost 2h debugging it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can follow progress here
Proposed Changes
require()
function with modules:audio
,badusb
,dialog
,display
,device
/flipper
,gpio
,http
,ir
,keyboard
/input
,math
,notification
,serial
,storage
,subghz
,submenu
,widget
andwifi
gpio.dacWrite
,parse_int
,to_string
,to_hex_string
,to_lower_case
andto_upper_case
__filepath
,__dirpath
andBRUCE_VERSION
Types of Changes
Bugfix, New Feature
Verification
You can copy a Flipper Zero JS script and run it on Bruce - it should work if it only uses functions from this list:
#748
And if it follows this syntax:
https://github.com/jamisonderek/flipper-zero-tutorials/wiki/JavaScript
Other FZ syntax, like the official one, is slightly incompatible with this version.
User-Facing Change
Further Comments