CI: Only cache one valgrind per arch #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
valgrind-caching
branch
from
843b955 to
4b38b09
Compare
mkannwischer
force-pushed
the
valgrind-caching
branch
6 times, most recently
from
e3b2652 to
4e10cf2
Compare
We are using a patched valgrind for the ct tests which is built in CI and then cached in the Github Cache. Currently we are using many different compilers for these tests. Currently, for each of these compilers valgrind is recompiled and cached taking up 600-800 MB per each of the 26 compiler/arch combinations. We only have 10 GB of cache, so we are constantly triggering cache evictions. This leads to painfully slow tests for other tests that due to that have to recompile gcc which takes around 45 minutes. This commit changes the cache key for valgrind to only contain the OS and arch, but not the compiler version. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
force-pushed
the
valgrind-caching
branch
from
4e10cf2 to
fd396fe
Compare
hanno-becker
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using a patched valgrind for the ct tests
which is built in CI and then cached in the Github Cache. Currently we are using many different compilers for these tests. Currently, for each of these compilers valgrind is recompiled and cached taking up 600-800 MB per
each of the 26 compiler/arch combinations.
We only have 10 GB of cache, so we are constantly triggering cache evictions.
This leads to painfully slow tests for other tests that due to that have to recompile gcc which takes around 45 minutes.
This commit changes the cache key for valgrind to only contain the OS and arch, but not the compiler version.