HOL-Light: Add support for MacOS #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hanno-becker
force-pushed
the
hol_light_mac
branch
from
f24cc1c to
138a88f
Compare
The HOL-Light/s2n-bignum proofs expect ELF formatted object files, but compilation on MacOS produces Mach-O object files. This commit modifies the makefile for the HOL-Light proofs in mlkem-native to explicitly convert from Mach-O to ELF using gobjcopy. Unfortunately, there does not seem to be a way to get a version of `objcopy` through `nix` that supports the required conversion, hence we need to fall back to documentation and expressive error messages to nudge the user to manually install `gobjcopy` via `brew install binutils` when it cannot be found. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
hol_light_mac
branch
from
138a88f to
dfb3166
Compare
rod-chapman
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HOL-Light/s2n-bignum proofs expect ELF formatted object files, but compilation on MacOS produces Mach-O object files.
This commit modifies the makefile for the HOL-Light proofs in mlkem-native to explicitly convert from Mach-O to ELF using gobjcopy.
Unfortunately, there does not seem to be a way to get a version of
objcopythroughnixthat supports the required conversion, hence we need to fall back to documentation and expressive error messages to nudge the user to manually installgobjcopyviabrew install binutilswhen it cannot be found.