Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS-LC integration test #654

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add AWS-LC integration test #654

wants to merge 2 commits into from

Conversation

hanno-becker
Copy link
Contributor

@hanno-becker hanno-becker commented Jan 13, 2025

This commit extends the CI with an integration test for AWS-LC.

The integration test currently works with the mlkem_native branch from the fork hanno-becker/aws-lc
GitHub, which

  • Removes the reference implementation
  • Provides a script for importing mlkem-native
  • Provides the glue code between mlkem-native's own API and the API expected by AWS-LC.

The CI checks that mlkem-native successfully integrated to this fork, by building and running basic tests of AWS-LC in FIPS and non-FIPS mode.

@hanno-becker hanno-becker force-pushed the aws_lc_integration branch 3 times, most recently from b814b55 to 9f0037d Compare January 13, 2025 11:18
@hanno-becker hanno-becker marked this pull request as ready for review January 13, 2025 11:18
@hanno-becker hanno-becker requested review from a team and mkannwischer January 13, 2025 11:18
@hanno-becker hanno-becker marked this pull request as draft January 13, 2025 11:19
@hanno-becker hanno-becker removed the request for review from mkannwischer January 13, 2025 11:19
@hanno-becker hanno-becker changed the title Add basic AWS-LC integration test Add C-only AWS-LC integration test Jan 17, 2025
@hanno-becker hanno-becker force-pushed the aws_lc_integration branch 2 times, most recently from c12e6fb to 076d65a Compare February 3, 2025 11:55
@mkannwischer mkannwischer removed the request for review from a team February 4, 2025 02:37
@hanno-becker hanno-becker force-pushed the aws_lc_integration branch 2 times, most recently from 414b211 to 0eb614f Compare February 5, 2025 05:33
@hanno-becker hanno-becker changed the title Add C-only AWS-LC integration test Add AWS-LC integration test Feb 5, 2025
@hanno-becker hanno-becker force-pushed the aws_lc_integration branch 10 times, most recently from 744fe93 to a6e16d6 Compare February 5, 2025 20:15
@hanno-becker hanno-becker force-pushed the aws_lc_integration branch 14 times, most recently from d75ea92 to 3306857 Compare February 6, 2025 12:26
This commit extends the CI with an integration test for AWS-LC.

The integration test currently works with the `mlkem_native`
branch from the fork `hanno-becker/aws-lc`, which
- Removes the reference implementation
- Provides an importer.sh for importing mlkem-native
- Provides the glue code between mlkem-native's own API
  and the API expected by AWS-LC.
- As a temporary change, it disables `-Werror=redundant-decls`,
  because mlkem-native does not yet support it.

The CI checks that mlkem-native successfully integrated to this
fork, by building and running basic tests of AWS-LC in FIPS
and non-FIPS mode.

Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
@hanno-becker hanno-becker force-pushed the aws_lc_integration branch 5 times, most recently from 8d5ecd0 to 8723b62 Compare February 6, 2025 13:21
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant