Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase flexibility of player test cases #4485

Merged
merged 6 commits into from
Mar 20, 2019
Merged

Increase flexibility of player test cases #4485

merged 6 commits into from
Mar 20, 2019

Conversation

peppy
Copy link
Member

@peppy peppy commented Mar 18, 2019 •
edited by smoogipoo
Loading

Splits TestCasePlayer into AllPlayersTestCase and PlayerTestCase rather than trying to make a one-size-fits-all. Results in much more legible code.

@peppy peppy mentioned this pull request Mar 18, 2019
Merged
1 task
@peppy peppy force-pushed the player-test-flexibility branch from 4a0d14a to 025a266 Compare March 19, 2019 08:02
@smoogipoo smoogipoo merged commit 268d3c6 into ppy:master Mar 20, 2019
@peppy peppy deleted the player-test-flexibility branch March 22, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:gameplay type:testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @smoogipoo