Add slider ticks. #359
Merged
Add slider ticks. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom94
reviewed
Feb 14, 2017
|
|
||
| namespace osu.Game.Modes.Osu.Objects.Drawables.Pieces | ||
| { | ||
| public class SliderTicksRenderer : Container<DrawableSliderTick> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
reviewed
Feb 14, 2017
osu.Game.Modes.Osu/Objects/Slider.cs
Outdated
| var multipliedStartBeatLength = beatmap.BeatLengthAt(StartTime, true); | ||
|
|
||
| Velocity = 100 / multipliedStartBeatLength * baseDifficulty.SliderMultiplier; | ||
| TickDistance = (100 * baseDifficulty.SliderMultiplier) / baseDifficulty.SliderTickRate / (multipliedStartBeatLength / startBeatLength); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Conflicts: osu.Game.Modes.Osu/Objects/Drawables/DrawableSlider.cs osu.Game.Modes.Osu/Objects/Slider.cs
Tom94
reviewed
Feb 16, 2017
osu.Game.Modes.Osu/Objects/Slider.cs
Outdated
|
|
||
| Velocity = 100 / multipliedStartBeatLength * baseDifficulty.SliderMultiplier; | ||
| TickDistance = (100 * baseDifficulty.SliderMultiplier) / baseDifficulty.SliderTickRate / (multipliedStartBeatLength / startBeatLength); | ||
| Velocity = baseVelocity / (timingPoint.BeatLength * velocityAdjustment); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- Applies to Slider Ticks and start circle. repeat/endpoints still need addressing. - Removed SliderTicksLayer abstraction for now.
Damnae
commented
Feb 16, 2017
| Judgement.Result = ShouldHit ? HitResult.Hit : HitResult.Miss; | ||
| { | ||
| j.Result = Tracking ? HitResult.Hit : HitResult.Miss; | ||
| j.Score = Tracking ? OsuScoreResult.SliderTick : OsuScoreResult.Miss; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
… DrawableHitObjects.
Tom94
reviewed
Feb 16, 2017
| @@ -85,6 +84,19 @@ protected override void LoadComplete() | |||
| Expire(true); | |||
| } | |||
|
|
|||
| private List<DrawableHitObject> nestedHitObjects; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tom94
approved these changes
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.