Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argon style judgement counter #32297

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LukynkaCZE
Copy link
Contributor

This PR adds Argon style judgement counter skin component

I was originally gonna add ability to change the font on the existing one because honestly the old font really doesn't look great on it but I realized there is no numeric font variant for Torus and it looked really off with the number width changing all the time so I decided to make new argon styled one instead

The label colors are based on the hit result colors (same as existing one). The actual counter text is white by default but when "Show Label" is turned off, it changes to hit result colors so its obvious which number is what

argon.judgement.counter.mp4

@ItsShamed
Copy link
Contributor

I would have hoped for it to look like the Argon Key Counter (like in the Figma designs)

image

@LukynkaCZE
Copy link
Contributor Author

I would have hoped for it to look like the Argon Key Counter (like in the Figma designs)

image

I think it would be too confusing to have 2 components with the same design as key counter. PF, GD, PS, X also don't make too much sense in my opinion, especially when not colour coded. But that is just my opinion obv, open to suggestions. I reused the argon counters since they're used for other metrics already and I think they look great

@felipemarins
Copy link
Contributor

As I suggested on #30407, if you're going to use the figma design, I think you can add colours to the lines above the judgements. As for the judgement names on the figma, I agree that changing that would be preferable.

@peppy peppy self-requested a review March 10, 2025 08:41
@BunnyTub
Copy link

BunnyTub commented Apr 8, 2025

I don't know if I'm the only one, but the color on the argon wire frame pops really well with the design language of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants