Fix quick-deleting unselected slider path control point also deleting all selected control points #31348

bdach · 2024-12-30T08:47:05Z

Logic matches corresponding quick-delete logic in

osu/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs

Lines 307 to 316 in 130802e

    
           private void handleQuickDeletion(SelectionBlueprint<T> blueprint) 
        
           { 
        
               if (blueprint.HandleQuickDeletion()) 
        
                   return; 
        
               if (!blueprint.IsSelected) 
        
                   DeleteItems(new[] { blueprint.Item }); 
        
               else 
        
                   DeleteSelected(); 
        
           }

.

… all selected control points Closes ppy#31308. Logic matches corresponding quick-delete logic in https://github.com/ppy/osu/blob/130802e48048c134c6c8f19c77e3e032834acf72/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs#L307-L316.

bdach added 2 commits December 30, 2024 09:42

Add failing test coverage

aa67f87

bdach added ruleset/osu! area:editor labels Dec 30, 2024

pull-request-size bot added the size/L label Dec 30, 2024

bdach self-assigned this Dec 30, 2024

bdach mentioned this pull request Dec 30, 2024

Fix slider end drag marker blocking open of control point piece context menus #31350

Merged

1 task

smoogipoo approved these changes Dec 30, 2024

View reviewed changes

smoogipoo merged commit c56a6ed into ppy:master Dec 30, 2024
10 checks passed

bdach deleted the fix-slider-quick-delete branch December 30, 2024 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix quick-deleting unselected slider path control point also deleting all selected control points #31348

Fix quick-deleting unselected slider path control point also deleting all selected control points #31348

bdach commented Dec 30, 2024

	private void handleQuickDeletion(SelectionBlueprint<T> blueprint)
	{
	if (blueprint.HandleQuickDeletion())
	return;

	if (!blueprint.IsSelected)
	DeleteItems(new[] { blueprint.Item });
	else
	DeleteSelected();
	}

Fix quick-deleting unselected slider path control point also deleting all selected control points #31348

Fix quick-deleting unselected slider path control point also deleting all selected control points #31348

Conversation

bdach commented Dec 30, 2024