Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended difficulty numerical value near filter in beatmap listing #31101

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Dec 12, 2024

Relevant web code: https://github.com/ppy/osu-web/blob/027026fccc91525e39cee5d2f369f1b343eb1bf1/app/Libraries/Search/BeatmapsetSearchParams.php#L98-L101

The tests in TestSceneBeatmapRecommendations occasionally fail to populate ruleset statistics and I don't know how to fix it.

Kapture 2024-12-12 at 15 37 57

smoogipoo
smoogipoo previously approved these changes Dec 13, 2024
smoogipoo
smoogipoo previously approved these changes Dec 13, 2024
@smoogipoo smoogipoo merged commit f84c67b into ppy:master Dec 13, 2024
10 checks passed
@Joehuu Joehuu deleted the recommended-diff-beatmap-listing branch December 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants