Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter out currently playing rooms #31073

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Dec 11, 2024

Addresses https://osu.ppy.sh/community/forums/topics/2013293?n=1.

2024-12-11.13-10-42.mp4

Contains some renames, so per-commit review may be advisable. See 637fe07 for rationale.

@Joehuu
Copy link
Member

Joehuu commented Dec 11, 2024

The text "Currently playing" should probably be changed to "Currently listening to" maybe.

We also seem to have a RoomStatusPlaying that never worked in MultiplayerClient and demonstrated in TestSceneDrawableRoom wrongly (i.e. makes no sense in a playlist context, only multiplayer) nvm saw other PR:
Screenshot 2024-12-10 at 8 43 02 PM

@bdach
Copy link
Collaborator Author

bdach commented Dec 12, 2024

The text "Currently playing" should probably be changed to "Currently listening to" maybe.

Doesn't make much sense to me and is borderline out of scope. "Playing {beatmap} next" I'd maybe agree with.

@Joehuu
Copy link
Member

Joehuu commented Dec 12, 2024

I wanted to get rid of the "playing" term there to avoid confusion, but using "next" in the idle state works for me.

@peppy peppy self-requested a review December 12, 2024 04:30
@peppy
Copy link
Member

peppy commented Dec 12, 2024

Might be good to have this setting remembered in config, similar to the dropdown next to it.

Not sure about the text for the checkbox, I prefer the stable "Show in-progress rooms" I think?

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented

@peppy peppy self-requested a review December 13, 2024 06:12
@peppy peppy enabled auto-merge December 13, 2024 06:43
@smoogipoo smoogipoo disabled auto-merge December 13, 2024 08:03
@smoogipoo smoogipoo merged commit 2930db5 into ppy:master Dec 13, 2024
8 of 10 checks passed
@bdach bdach deleted the filter-playing-rooms branch January 8, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants