-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to filter out currently playing rooms #31073
Conversation
I need the "status" term free for an upcoming change. And web calls this parameter "mode" as well: https://github.com/ppy/osu-web/blob/642e973f916f315fb505aa79d4376675d0a2ec95/app/Models/Multiplayer/Room.php#L184-L199 so it works in my head.
Doesn't make much sense to me and is borderline out of scope. |
I wanted to get rid of the "playing" term there to avoid confusion, but using "next" in the idle state works for me. |
Might be good to have this setting remembered in config, similar to the dropdown next to it. Not sure about the text for the checkbox, I prefer the stable "Show in-progress rooms" I think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented
Addresses https://osu.ppy.sh/community/forums/topics/2013293?n=1.
2024-12-11.13-10-42.mp4
Contains some renames, so per-commit review may be advisable. See 637fe07 for rationale.