Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reading as a skill in osu!taiko #30538

Closed
wants to merge 28 commits into from

Conversation

Lawtrohux
Copy link
Member

Introduces the Reading Skill and EffectiveBPM for osu!taiko. The main takeaway is high SV (Slider Velocity) gives a bonus based on a per-object effectiveBPM. This does also mean HR now gives an SR Bonus, however its fixed difficulty pp multiplier has been removed to offset these changes. Similarly, the convert pp nerf has been slightly shifted alongside the addition of reading.

Low SV does not contain considerations within this build. This is primarily due to continued discussions about its impact on pp vs its impact on sr when it comes to mods like hidden and flashlight.

  • Uses a sigmoid function to calculate the influence of high SV on difficulty. The function’s centre is around a predefined effective BPM range,
  • Incorporates a calculation for object density based on DeltaTime. this currently is only utilised as an attribute but provides a data value for future HD and FL considerations.
  • LoadEffectiveBPM: Retrieves the current slider velocity from scroll_speed by object. My access methods may be a little messy, however.

Changes are viewable at Huismetbenen

Should #30536 get merged DifficultyCalculationUtils can be used instead for the sigmoid.

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=taiko

Copy link

@Lawtrohux
Copy link
Member Author

Lawtrohux commented Nov 11, 2024

@smoogipoo is it possible to get a converts excluded and a converts only smoogisheet? Also ranked only if preferable, gimmick loved maps seemingly are problematic.

Thank you in advance.

@smoogipoo
Copy link
Contributor

I can't really do converts only right now, but I can do converts excluded.

!diffcalc
RULESET=taiko
NO_CONVERTS=1

Copy link

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/11791562075

Copy link

@sw1tchbl4d3r
Copy link
Member

@smoogipoo can we get another sheet for this?

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=taiko

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=taiko
NO_CONVERTS=1

Copy link

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/11987626602

Copy link

Copy link

@Lawtrohux
Copy link
Member Author

I'm closing with in favour of (probably) grouping this pr together with the upcoming rhythm rework, as done with the previous rework. However code stays as is, values lgtm.

@Lawtrohux Lawtrohux closed this Nov 28, 2024
@Lawtrohux Lawtrohux deleted the reading-release branch December 3, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants