-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ModMirror and rate adjusting mods ranked #29324
base: master
Are you sure you want to change the base?
Conversation
stanriders
commented
Aug 7, 2024
•
edited
Loading
edited
- Requires Enforce real time difficulty for mod combinations which are not stored in the database osu-queue-score-statistics#274
- Deploy and testing of the change above
I'm well aware that people want this but please just let us try deploying that other PR first as a baseline to make sure everything doesn't just die from that alone. I dunno if I'd be willing to risk just dropping this change into production and seeing how hard it explodes - would definitely be in favour of a more careful rollout, throughput measurements included. |
I'm not sure why you assume this needs to be deployed before thoroughly testing the deploy of the processing change, this PR can wait until that for sure |
I'm not. I'm trying to communicate what I think the process for this should be and manage expectations. For everyone's sake, not only yours. Other people read these threads and draw conclusions, not always correct ones. |
Sure, I'd consider this change sort of a "second phase" of realtime calculation testing before ranking any other mods/mod settings as well |