Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made transition from 0 combo-based misscount to 1 smooth #29269

Closed
wants to merge 4 commits into from

Conversation

Givikap120
Copy link
Contributor

@Givikap120 Givikap120 commented Aug 3, 2024

The effect is mainly for pp-counter looking better.
But it's also can be useful in some rare case where 1 combo difference can result in huge pp difference.
Demonstration:

osu.2024-08-03.11-54-22-110.mp4

@smoogipoo smoogipoo requested a review from a team August 3, 2024 10:10
@smoogipoo
Copy link
Contributor

!diffcalc

Copy link

github-actions bot commented Aug 3, 2024

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10227202601

@peppy
Copy link
Member

peppy commented Aug 7, 2024

!diffcalc

Copy link

github-actions bot commented Aug 7, 2024

@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 7, 2024
Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding complexity for pretty much no benefit - "smooth" curve is as arbitrary as the discontinuous one and the difference in values is negligible

@Givikap120 Givikap120 closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants