Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow horizontal scrolling on mod select overlay anywhere on the screen #29249

Merged
merged 1 commit into from
Aug 2, 2024

Allow horizontal scrolling on mod select overlay anywhere on the screen

7690427
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Allow horizontal scrolling on mod select overlay anywhere on the screen #29249

Allow horizontal scrolling on mod select overlay anywhere on the screen
7690427
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed Aug 2, 2024 in 1s

10281 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Windows-SingleThread.trx

10356 tests were completed in 2559s with 10281 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Online.TestSceneChatOverlay 43✅ 1❌ 12s

❌ osu.Game.Tests.Visual.Online.TestSceneChatOverlay

✅ TestBasic
✅ TestBasic
✅ TestChannelCloseButton
✅ TestChannelCloseButton
✅ TestChannelSelection
✅ TestChannelSelection
✅ TestChatCommand
✅ TestChatCommand
✅ TestChatHeight
✅ TestChatHeight
✅ TestChatReport
✅ TestChatReport
✅ TestConstructor
✅ TestConstructor
✅ TestHighlightOnAnotherChannel
✅ TestHighlightOnAnotherChannel
✅ TestHighlightOnCurrentChannel
✅ TestHighlightOnCurrentChannel
✅ TestHighlightOnLeftChannel
✅ TestHighlightOnLeftChannel
✅ TestHighlightWhileChatNeverOpen
✅ TestHighlightWhileChatNeverOpen
✅ TestHighlightWithNullChannel
✅ TestHighlightWithNullChannel
✅ TestKeyboardCloseAndRestoreChannel
✅ TestKeyboardCloseAndRestoreChannel
✅ TestKeyboardNewChannel
✅ TestKeyboardNewChannel
❌ TestKeyboardNextChannel
	"wait for join completed" timed out
✅ TestKeyboardNextChannel
✅ TestMultiplayerChannelIsNotShown
✅ TestMultiplayerChannelIsNotShown
✅ TestRemoveMessages
✅ TestRemoveMessages
✅ TestSearchInListing
✅ TestSearchInListing
✅ TestShowHide
✅ TestShowHide
✅ TestSlowLoadingChannel
✅ TestSlowLoadingChannel
✅ TestTextBoxRetainsFocus
✅ TestTextBoxRetainsFocus
✅ TestTextBoxSavePerChannel
✅ TestTextBoxSavePerChannel

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Online.TestSceneChatOverlay ► TestKeyboardNextChannel

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "wait for join completed" timed out
Raw output
"wait for join completed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)