Fix AccuracyCircle sounds stopping when its ScorePanel is contracted #29215
Conversation
| @@ -100,6 +100,7 @@ public partial class ScorePanel : CompositeDrawable, IStateful<PanelState> | |||
| private AudioContainer audioContent = null!; | |||
|
|
|||
| private bool displayWithFlair; | |||
| private readonly bool isNewLocalScore; | |||
There was a problem hiding this comment.
Created this value due to displayWithFlair being set to false in updateState().
| else | ||
| { | ||
| middleLayerContentContainer.Add(expandedPanelMiddleContent = middleLayerContent = new ExpandedPanelMiddleContent(Score, displayWithFlair) { Alpha = 0 }); | ||
| if (expandedPanelMiddleContent != null) expandedPanelMiddleContent.AlwaysPresent = true; |
There was a problem hiding this comment.
I don't get it. The AlwaysPresent set is presumably the fix here yes? Then what is going on with everything else in this diff?
Why does isNewLocalScore exist? What's with the random changes to hiding and showing the panel?
There was a problem hiding this comment.
In the original implementation, the top/middleLayerContent would expire upon changing the state. My implementation prevents middleLayerContent from being deleted if the ScorePanel's displayWithFlair is true, thus preventing the sound from stopping.
I removed isNewLocalScore and replaced all usages with displayWithFlair. Consequently, I also removed the line of code that was setting displayWithFlair since it is no longer used (it was previously used in constructing ExpandedPanelMiddleContent, which is now only constructed once and then shown/hidden).
Additionally, I added AlwaysPresent to the expandedPanelMiddleContent. Without this, when Alpha was 0, the sound would stop.
…/osu into fix-applause-sound-stop
|
So I spent a long time deciphering this fix, and I think I understand what it's trying to go for now. Unfortunately it is not enough. See video below. 2024-08-07.15-28-20.mp4The video is a bit crap but the general scenario is to start clicking the collapsed panels on the left of the expanded one until the sound stops. Undoubtedly something or other to do with the panel getting masked away or something. |
|
Hi, just wanted to let you know I am still interested in working on this, my schedule is quite busy right now. I'll convert this to a draft for now. |
|
I'm confused, why did this get drafted? Is this PR in a complete state for a re-review right now or not? |
|
Hi, sorry for the confusion, this PR is not ready. |
|
Going to close this one for now, please consider reopening if you want to take it on. |
osuresultscreensound.mp4
fixes #29207
depends on ppy/osu-framework#6359