Use new footer for daily challenge #29165

Joehuu · 2024-07-28T07:40:58Z

Loosely needed for #29163, so there's feedback that the mods are applied.

The mod display overlap is not the best, but neither is having more dead space on the bottom. Added enough padding so that the actual content is still readable.

Restricted to one right button for the footer as it's already wide in the designs, and I believe we only need one. For multiplayer, we can probably use the left buttons for spectate/timer or somewhere else.

Kapture.2024-07-28.at.00.25.39.mp4

Known issues:

Deselect button position not updating (existed before PR and believed someone reported on Discord too)

…ds display

bdach · 2024-07-29T07:31:24Z

Deselect button position not updating (existed before PR and believed someone reported on Discord too)

You can't seriously PR this sort of stuff and expect it to be merged... Why isn't this fixed? Do you seriously believe I'd push something this obviously broken live?

I'll look into fixing but dear lord. It's a different thing when something's broken on already live UI components, and another when you're pushing UI breakage where there was none before.

Joehuu · 2024-07-29T08:04:16Z

Didn't find a solution at the time, so left it in OP. It uses padding for positioning the deselect button, so you would need to update that every frame somehow.

Maybe a better solution is just not to resize the "free mods" button? That's easier to do.

peppy · 2024-07-29T08:25:58Z

Maybe a better solution is just not to resize the "free mods" button? That's easier to do.

This was my original proposal which hasn't yet been acted on.

bdach · 2024-07-29T08:32:09Z

This was my original proposal which hasn't yet been acted on.

Where was this and who's supposed to be acting on it?

I'd like to move fast on this if possible because dear lord am I sick of the indolence when attempting to push any sort of design change.

peppy · 2024-07-29T08:35:44Z

Go for it. I don't think anyone's acting on it. https://discord.com/channels/188630481301012481/188630652340404224/1260510586442354759

bdach

I was hoping I could just fix the free mods button thing and move on but the structure on this is pretty tragic to the point wherein I feel like I need to put a stop to this before things escalate too far to badness of a scale which I do not wish to deal with later

bdach · 2024-07-29T14:37:17Z

osu.Game/Graphics/UserInterface/ShearedButton.cs

+        public void AppearFromLeft(double delay)
+        {
+            Content.FinishTransforms();
+            Content.MoveToX(-300f)
+                   .FadeOut()
+                   .Delay(delay)
+                   .MoveToX(0f, 240, Easing.OutCubic)
+                   .FadeIn(240, Easing.OutCubic);
+        }
+
+        public void AppearFromBottom()
+        {
+            Content.FinishTransforms();
+            Content.MoveToY(100f)
+                   .FadeOut()
+                   .MoveToY(0f, 240, Easing.OutCubic)
+                   .FadeIn(240, Easing.OutCubic);
+        }
+
+        public void DisappearToRight(bool expire)
+        {
+            Content.FinishTransforms();
+            Content.FadeOut(240, Easing.InOutCubic)
+                   .MoveToX(300f, 360, Easing.InOutCubic);
+
+            if (expire)
+                this.Delay(Content.LatestTransformEndTime - Time.Current).Expire();
+        }
+
+        public void DisappearToBottom(bool expire)
+        {
+            Content.FinishTransforms();
+            Content.FadeOut(240, Easing.InOutCubic)
+                   .MoveToY(100f, 240, Easing.InOutCubic);
+
+            if (expire)
+                this.Delay(Content.LatestTransformEndTime - Time.Current).Expire();
+        }


I have so many questions. Like:

Why is this here?

Why are transforms being applied to Content?

Why do these have expire bool flags?

Why is this button trying to apply transforms to itself rather than the footer animating it?

I guess ScreenFooterButton also does this, which I argue is just as bad? And the fact that this is starting to spread means that it's even worse?

tagging in @frenzibyte since you authored that other stuff

I'll answer these set of questions for ScreenFooterButton, I don't agree with this existing here.

In ScreenFooterButton context, the button is used exclusively by the footer, so it's either/or whether the animation is defined by the footer or placed in the footer button itself (but it was suggested to put the animation in the button, see Add basic animation to new footer and buttons #28184 (comment))

Because the ScreenFooterButton may be placed in a fill flow, at which point the animation will be interrupted by the flow layout code. Compare this to the existence of TopLevelContent in ModSelectColumn to animate it, but I expect you to say it's different because the component is exposing it for the overlay to explicitly apply animation to it, I dunno.

I suppose you're asking this because I can supposedly do button.Expire() from the footer and it'll still expire after the animation is applied, but no, because the animation is applied on Content not this.

Add basic animation to new footer and buttons #28184 (comment)

Ok well as long as you can delete this stuff from ShearedButton I'll look away from ScreenFooterButton.

bdach · 2024-07-29T14:40:39Z

osu.Game/Screens/Footer/ScreenFooter.cs

+        // TODO: this should take the screen's colourProvider instead. hardcode plum for now as daily challenge is the only usage shown to users
        [Cached]
-        private readonly OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Aquamarine);
+        private readonly OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Plum);


This sort of kicking the can down the road does not inspire confidence, what is the plan with this?

Using the ScreenFooter anywhere other than song select is not something I wanted to happen immediately, I was in the mindset of "we'll cross that bridge when we get to it". But the daily challenge screen came, and I think it's a great idea to try the screen footer there, to resolve the issue of seeing which mods are currently selected, but there are minor concerns like this that I would hope to be left out until follow-up PRs that aim to get the new song select live.

I will try to see if I can address this alongside what I had mentioned in #29165 (comment) already, though.

bdach · 2024-07-29T14:43:57Z

osu.Game/Screens/Footer/ScreenFooter.cs

+        private void makeLeftButtonAppearFromLeft(ScreenFooterButton button, int index, int count, float startDelay)
            => button.AppearFromLeft(startDelay + (count - index) * delay_per_button);

-        private void makeButtonAppearFromBottom(ScreenFooterButton button, int index)
+        private void makeLeftButtonAppearFromBottom(ScreenFooterButton button, int index)
            => button.AppearFromBottom(index * delay_per_button);

-        private void makeButtonDisappearToRight(ScreenFooterButton button, int index, int count, bool expire)
+        private void makeLeftButtonDisappearToRight(ScreenFooterButton button, int index, int count, bool expire)
            => button.DisappearToRight((count - index) * delay_per_button, expire);

-        private void makeButtonDisappearToBottom(ScreenFooterButton button, int index, int count, bool expire)
+        private void makeLeftButtonDisappearToBottom(ScreenFooterButton button, int index, int count, bool expire)
            => button.DisappearToBottom((count - index) * delay_per_button, expire);

+        private void makeRightButtonAppearFromLeft(ShearedButton button, float startDelay)
+            => button.AppearFromLeft(startDelay);
+
+        private void makeRightButtonAppearFromBottom(ShearedButton button)
+            => button.AppearFromBottom();
+
+        private void makeRightButtonDisappearToRight(ShearedButton button, bool expire)
+            => button.DisappearToRight(expire);
+
+        private void makeRightButtonDisappearToBottom(ShearedButton button, bool expire)
+            => button.DisappearToBottom(expire);


oh and this is also pretty terrible but i am hoping that if the buttons can stop animating themselves for whatever reason we can just get rid of this entire block

vatei · 2024-07-29T14:50:15Z

Go for it. I don't think anyone's acting on it. https://discord.com/channels/188630481301012481/188630652340404224/1260510586442354759

Regarding the deselect button, I agree that it feels weird, but maybe it's just because it's out of place there?
I made a small edit where I moved the button, and it feels more natural and in line with the rest of the design to me
(Maybe it should also match the size of the back button to really feel like a button too)

bdach · 2024-07-29T14:53:09Z

I made a small edit where I moved the button, and it feels more natural and in line with the rest of the design to me

Disagree. Before you had buttons on the left, non-button content on the right. Your proposal mixes it so it's buttons - not buttons - button again.

vatei · 2024-07-29T14:55:22Z

I made a small edit where I moved the button, and it feels more natural and in line with the rest of the design to me

Disagree. Before you had buttons on the left, non-button content on the right. Your proposal mixes it so it's buttons - not buttons - button again.

I'd argue it's thematically separated in the edit, general UI left, and mod select specific UI right
But I see the point

Tanza3D · 2024-07-29T23:19:08Z

I'd definitely personally agree when taking into account where the user would expect it to be that it's best to have the deselect button on the right, grouped with the rest of the mod-related info/items, as compared to floating somewhere on the left

Phippe · 2024-07-30T00:44:36Z

Another reply, I'm sorry, but having the button to the bottom right just feels right to me. It's where you'll find the Cancel/OK button on pretty much every OS. Additionally, having the information on the left and the input element on the right is way more common than the other way around. Finally, the button on the bottom right feels properly anchored, whereas the current button is just kind of there, floating in space. For me, the only thing in favour of the current position is that it's close to the Mods button, so you don't have to move the cursor very far to quickly open the Mods menu and deselect everything.

frenzibyte · 2024-07-30T02:36:40Z

osu.Game/Screens/Footer/ScreenFooter.cs

+            }
+        }
+
+        public void SetRightButton(ShearedButton? button)


This is absolutely not how I imagined this to be implemented.

frenzibyte · 2024-07-30T02:53:48Z

The direction this PR is heading with the footer code is quite opposite to what I envisioned. A discussion in discord at least would've been nice before you head with this diff.

Main issues to point out:

The existing footer button animations are made specifically for the footer button. I would soon move all the footer button animation logic to a FooterButtonFlow class than to keep it in the class and duplicate over it.
SetRightButtons should not exist. I'm expecting the content display logic in RegisterActiveOverlayContainer to be expanded to screens instead, making each screen able to offer its set of buttons on the right, left, center, anywhere.

I'll look into this the upcoming days and put what I have in mind into code.

Joehuu added 7 commits July 27, 2024 23:11

Prepend left to left button logic

232867f

Prepare free mods button

4325149

Add text weight to ShearedButton

25e14b9

Change default color scheme of screen footer to plum for now

43b8cf2

Add LetsGoButton

c1b8758

Implement right button logic and utilize new footer in daily challenge

785bc69

Add a bit more padding to the bottom so text doesn't conflict with mo…

285d37e

…ds display

Joehuu added type:cosmetic area:daily-challenge labels Jul 28, 2024

pull-request-size bot added the size/L label Jul 28, 2024

bdach requested changes Jul 29, 2024

View reviewed changes

bdach reviewed Jul 29, 2024

View reviewed changes

frenzibyte reviewed Jul 30, 2024

View reviewed changes

frenzibyte added the blocked Don't merge this. label Jul 30, 2024

peppy assigned frenzibyte Jul 30, 2024

frenzibyte mentioned this pull request Aug 7, 2024

Song select redesign #22204

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new footer for daily challenge #29165

Use new footer for daily challenge #29165

Joehuu commented Jul 28, 2024

bdach commented Jul 29, 2024 •

edited

Loading

Joehuu commented Jul 29, 2024

peppy commented Jul 29, 2024

bdach commented Jul 29, 2024

peppy commented Jul 29, 2024

bdach left a comment

bdach Jul 29, 2024

frenzibyte Jul 30, 2024

bdach Jul 30, 2024

bdach Jul 29, 2024

frenzibyte Jul 30, 2024

bdach Jul 29, 2024

vatei commented Jul 29, 2024

bdach commented Jul 29, 2024

vatei commented Jul 29, 2024

Tanza3D commented Jul 29, 2024

Phippe commented Jul 30, 2024

frenzibyte Jul 30, 2024

frenzibyte commented Jul 30, 2024

Use new footer for daily challenge #29165

Are you sure you want to change the base?

Use new footer for daily challenge #29165

Conversation

Joehuu commented Jul 28, 2024

bdach commented Jul 29, 2024 • edited Loading

Joehuu commented Jul 29, 2024

peppy commented Jul 29, 2024

bdach commented Jul 29, 2024

peppy commented Jul 29, 2024

bdach left a comment

Choose a reason for hiding this comment

bdach Jul 29, 2024

Choose a reason for hiding this comment

frenzibyte Jul 30, 2024

Choose a reason for hiding this comment

bdach Jul 30, 2024

Choose a reason for hiding this comment

bdach Jul 29, 2024

Choose a reason for hiding this comment

frenzibyte Jul 30, 2024

Choose a reason for hiding this comment

bdach Jul 29, 2024

Choose a reason for hiding this comment

vatei commented Jul 29, 2024

bdach commented Jul 29, 2024

vatei commented Jul 29, 2024

Tanza3D commented Jul 29, 2024

Phippe commented Jul 30, 2024

frenzibyte Jul 30, 2024

Choose a reason for hiding this comment

frenzibyte commented Jul 30, 2024

bdach commented Jul 29, 2024 •

edited

Loading