Fix crash on drag selection via timeline while placement is active #28478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported in #28474, albeit the code changes proposed there did not fix the issue at all.
See 8b6385f for demonstration of the crash scenario. Basically what is happening there is:
SelectedItems
.osu/osu.Game/Screens/Edit/Compose/Components/Timeline/TimelineBlueprintContainer.cs
Lines 179 to 183 in 2d4121b
HitObjectComposer
decides to switch to the "select" tool, regardless of whythe selection changed.
osu/osu.Game/Rulesets/Edit/HitObjectComposer.cs
Lines 431 to 438 in 2d4121b
osu/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs
Lines 390 to 407 in 2d4121b
The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.
cc @Hecatia-Lapislazuli