Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relax mod for taiko #28472

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Implement relax mod for taiko #28472

merged 3 commits into from
Jun 17, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jun 13, 2024

RFC. Closes #7914.

The lack of this in lazer has been bugging me for a while.

This is a second try at implementing this. In the first one I tried to follow this idea of mixing input blockage and re-propagation of inputs to avoid changing hitobject classes. However, it didn't work because #3493 and #25010 will not allow it to work due to the "has input been handled this frame already" checks. Therefore if I was going to have to modify DHOs anyway to bypass that check then I beelined for the simplest possible / most obvious implementation instead. And yes it's slightly different than stable in behaviour because it doesn't "correct" user inputs like stable but /shrug at this point.

Also stable relax does the following things:

  • turns off a drum roll anti-mashing provision that doesn't even exist in lazer anymore
  • prevents failure - but other relax mod implementations in lazer don't do this, so neither does this

@Ratchet0203
Copy link

Probably out of scope for this PR, but I suggest removing color SR in taiko diffcalc for this mod since you can ignore colors.

@bdach
Copy link
Collaborator Author

bdach commented Jun 13, 2024

200% out of scope, mod is unranked by default anyway. Something for @ppy/taiko-pp-commitee to worry about if this survives review.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoogipoo smoogipoo merged commit 030853e into ppy:master Jun 17, 2024
12 of 17 checks passed
@bdach bdach deleted the taiko-mod-relax branch June 17, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax mod in osu!taiko is not implemented
3 participants