Implement event feed view for daily challenge screen #28468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next piece for #28136
2024-06-13.08-56-30.mp4
There's one ugly cast in here that I'd ask to look away from for the time being, if the series goes as I intend it to it will disappear in due time.
Link on the score total is supposed to eventually open results screen for said score. Only one "event type" supported for now, more may come later.
Implementation could theoretically use pooling but I dunno, didn't feel like complicating it. I wrote it to limit the number of present drawables at a time anyways (anything that gets masked off screen gets disposed immediately). Will do on request.