Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more descriptive HitObject names for debugger displays #28465

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Use more descriptive HitObject names for debugger displays #28465

merged 1 commit into from
Jun 13, 2024

Conversation

smoogipoo
Copy link
Contributor

No description provided.

@peppy peppy self-requested a review June 13, 2024 06:22
@peppy peppy merged commit b61a705 into ppy:master Jun 13, 2024
9 of 11 checks passed
@bdach
Copy link
Collaborator

bdach commented Jun 13, 2024

I was going to object to ToString() usage and instead suggest something that uses [DebuggerDisplay] instead or something but alas.

@smoogipoo
Copy link
Contributor Author

smoogipoo commented Jun 13, 2024 •
edited
Loading

I mostly intended this for the draw visualiser, which doesn't use DebuggerDisplay (yet?) :(

@bdach
Copy link
Collaborator

bdach commented Jun 13, 2024

which doesn't use DebuggerDisplay (yet?)

Given that DebuggerDisplayAttribute supports arbitrary expressions it's probably never.

Anyways I can live with this probably, just hoping nobody actually depended on the previous .ToString() output...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
size/XS type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoogipoo @bdach @peppy