Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Argon accuracy counter layout when under 10% and wireframe off #28443

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ColdVolcano
Copy link
Contributor

When under 10% accuracy, the argon accuracy counter would leave a blank space between the whole and fractional parts.
image

By applying the anchor to the number container and ignoring the label for sizing. we get a consistent visual with the rest of the counters.
image
Note that moving the anchor to only the container creates the opposite problem (empty spaces when wireframes are visible).

Only problem with this approach would be very long labels not applying it's size to the element in the skin editor, but with current localizations this does not happen.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@bdach bdach merged commit fb99dae into ppy:master Jun 11, 2024
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants