-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow previewing audio of playlist items #28333
Conversation
How much should I be nitpicking the visuals? Because to me that looks... not great... Progress circle aside:
|
I reduced the font size to allow for more to display (it was quite oversized before).
it's using half the previous padding (looked okay to me). trying to strike a balance between padding and information density. can increase back to 8px if preferred. |
We can reduce paddings but at the least if the difficulty icon is going to be that close to the preview, then the text on its right should be at least as close. Or the padding on the left should be slightly more, at the right padding's expense. Currently it just looks completely off imo. |
08ac3aa
to
75d961e
Compare
Minimal implementation. Sizing of progress circle isn't great but functionality is there.
osu.2024-05-27.at.08.10.00.mp4
Addresses #21315.