Reduce container nesting inside PathControlPointPiece
#28205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So now I have a way to draw circles without masking or uniform buffers, which improves performance by a lot:
Framework branch: https://github.com/ppy/osu-framework/compare/master...EVAST9919:hacky-circle?expand=1 |
peppy
approved these changes
May 19, 2024
Comment on lines
+196
to
+197
| Colour = colour; | ||
| Scale = new Vector2(hitObject.Scale); |
There was a problem hiding this comment.
Generally the reason we add the nested container in the first place is to isolate things like colour/scale from acting on this. It avoids cases where a drawable changes these values, but then they are changed from outside and overwrite the internal values.
Because this is a very local usage I'm willing to let this slide but keep this in mind for more generic cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards resolving #21495.
Can potentially be improved further by making a custom circle drawable which isn't a
CircularContainerwith aBoxinside. Though at this point we are already limited by the draw thread, so next step would probably be adding aBufferedContainerto the mix.Or better yet use a texture to draw circles to avoid masking overhead and only override
ReceivePositionalInputAt. It's would be possible to useCircularProgress, but with too many circles there's an overhead of switching between uniform buffers (which is even bigger than pushing/popping masking info at least for me).