-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum viable prototype of "daily challenge" feature #28195
Conversation
@bdach I'm not sure which change specifically caused this (likely the state handling of master: 2024-05-23.17.22.03.mp4this pr: 2024-05-23.17.21.06.mp4I think it might be faster if you check on this since you're more familiar with your changes. |
bfa23ec should do it I reckon. Code quality is... dubious in those parts 😅 |
2024-05-17.11-39-05.mp4
This would conclude what I would consider to be the first minimal releasable increment of this feature.
The daily challenge room is not filtered out of playlists yet despite prior discussion because things are set up such that exiting out of the playlist puts you into the lobby, so it kinda makes sense to me to keep it there for now (and hiding it is a bit annoying given current setup, so if we end up redoing the screen to be a completely separate thing then it'd be wasted effort).
The diffsize is pushing it, but most of the diff is visuals and tests, so I'm hoping it won't be an issue. Am willing to split stuff out if required, just don't wanna do it without causing more ceremony than necessary (see: dependency list).