Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate stateful menu items with right-click without closing the menu #28086

Merged
merged 6 commits into from
May 6, 2024

Conversation

424ever
Copy link
Contributor

@424ever 424ever commented May 3, 2024

This is a feature I first saw implemented in SerenityOS. It is for example usefull, when the user wants to add a beatmap to multiple collections in a multiplayer lobby.
menu.webm

@peppy
Copy link
Member

peppy commented May 4, 2024

I'd prefer this behaviour when right clicking (or adding that in addition to ctrl-click). I don't know where I've seen this done but it feels more natural to me.

Alternatively, make it the always-on behaviour for certain menus.

@pull-request-size pull-request-size bot added size/M and removed size/S labels May 4, 2024
@424ever 424ever changed the title Keep menus open when clicking a stateful item with CTRL held Activate stateful menu items with right-click without closing the menu May 4, 2024
@424ever
Copy link
Contributor Author

424ever commented May 4, 2024

Searching for right click I also found this issue talking about the same thing:
#10255
Where it seemingly was already decided to be handled via right click.

@peppy peppy self-requested a review May 5, 2024 13:14
@peppy
Copy link
Member

peppy commented May 6, 2024

The way this manages to work is a touch haphazard (detailed in inline comment) but I'm willing to let it slide just to get this behaviour in without framework changes.

Will wait for one more review just in case there's any strong objections.

@bdach bdach self-requested a review May 6, 2024 07:25
@bdach bdach merged commit 761d713 into ppy:master May 6, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to right-click collections context menu for adding beatmaps to multiple collections
4 participants