Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beatmap backgrounds loading default briefly before final display #28079

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix beatmap backgrounds loading default briefly before final display #28079

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1e9b6d
Fix beatmap backgrounds loading default briefly before final display
peppy May 3, 2024
d1a50ff
Remove redundant conditional access
bdach May 3, 2024
cf27366
Merge branch 'master' into fix-double-load-playlist-backgrounds
bdach May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion osu.Game/Beatmaps/Drawables/UpdateableBeatmapBackgroundSprite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,11 @@ protected override Drawable CreateDrawable(IBeatmapInfo? model)

private Drawable getDrawableForModel(IBeatmapInfo? model)
{
if (model == null)
return Empty();

// prefer online cover where available.
if (model?.BeatmapSet is IBeatmapSetOnlineInfo online)
if (model.BeatmapSet is IBeatmapSetOnlineInfo online)
return new OnlineBeatmapSetCover(online, beatmapSetCoverType);

if (model is BeatmapInfo localModel)
Expand Down
Loading