Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat overlay being far too large #28075

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented May 3, 2024

Before After
2024-05-03 12 31 53@2x 2024-05-03 12 30 59@2x

@bdach
Copy link
Collaborator

bdach commented May 3, 2024

The chat entry box texts used to line up with the actual chat lines above but no longer do now (although this seems to be possibly have been always terminally broken if your regional settings include showing AM/PM markers for time which is hilarious):

master this PR
osu_2024-05-03_07-41-51 osu_2024-05-03_07-42-22

Channel selector font size looks comically large now:

osu_2024-05-03_07-45-44

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@peppy
Copy link
Member Author

peppy commented May 3, 2024

I've fixed channel listing.

although this seems to be possibly have been always terminally broken if your regional settings

yeah i remember it being best-effort since aligning any better was hard (is still aligned for me):

2024-05-03 14 01 04@2x

out of scope i guess

@bdach bdach merged commit 3840e92 into ppy:master May 3, 2024
13 of 17 checks passed
@peppy peppy deleted the fix-chat-ui-scale branch May 4, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants