Update local metadata lookup cache more often #28067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As proposed in ppy#27332 (comment).
bdach
commented
May 2, 2024
Comment on lines
+178
to
+182
| // ensure to clobber any and all existing data to avoid accidental corruption. | ||
| outStream.SetLength(0); | ||
|
|
||
| using (var bz2 = new BZip2Stream(stream, CompressionMode.Decompress, false)) | ||
| bz2.CopyTo(outStream); |
There was a problem hiding this comment.
This is probably going to be the most contentious here (attempting to replace the cache file in situ). I did it this way because it seemed simpler. I guess I could try writing to yet another file and doing a file swapsie instead at the end but that seemed like it'd be much more complicated for very little gain because IO can and will go wrong anywhere and always...?
There was a problem hiding this comment.
I'm up for trying this, it's not conventionally how I'd do it but I'm interested to see how it plays out.
Seems to work well on macOS.
|
Checked windows, seems to behave fine. |
peppy
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. As proposed in #27332 (comment).
Refresh interval chosen is 1 month - seems like a decent compromise to me?
Testing was mostly manual here because automated is gonna be very awkward here. Some faffing about was done with
touchandddto simulate various fun things.