Fix mod search box not tracking external changes to focus state #27780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Mod selection area, the search bar's focus could be changed by pressing TAB. However, when clicking outside of the search bar, the focus would be killed but two TABs were required to get the focus back on the search bar. This happened because the action of clicking in an empty area would trigger the search bar to change its appearence, but not its internal state. In my solution, I made the OnClick function aware of the search bar's state, so it would not only change its appearance, but also its state. Now, after clicking in an empty area, there is only needed one TAB to select the search box again, as expected.
bdach
changed the title
bdach
requested changes
Apr 5, 2024
| @@ -953,7 +957,7 @@ protected override bool OnClick(ClickEvent e) | |||
| RequestScroll?.Invoke(this); | |||
|
|
|||
| // Killing focus is done here because it's the only feasible place on ModSelectOverlay you can click on without triggering any action. | |||
| Scheduler.Add(() => GetContainingInputManager().ChangeFocus(null)); | |||
| modSelectOverlayInstance.setTextBoxFocus(false); | |||
There was a problem hiding this comment.
This approach is insufficient. It only fixes the bug in the case wherein clicking the columns was specifically what took focus away from the textbox.
If any other component, such as the chat overlay, happens to take away focus, this stops working:
2024-04-05.10-41-36.remuxed.mp4
Note how after opening chat, it takes two tab presses to focus the textbox again.
The actual fix will probably involve looking at the actual focus state of the textbox rather than doing tracking in a separate flag.
bdach
approved these changes
Apr 19, 2024
|
I pretty much rewrote this but it's also such a minor change that I'm not going to request a second check, just going to roll forward with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Mod selection area, the search bar's focus could be changed by pressing TAB. However, when clicking outside of the search bar, the focus would be killed but two TABs were required to get the focus back on the search bar. This happened because the action of clicking in an empty area would trigger the search bar to change its appearence, but not its internal state. In my solution, I made the OnClick function aware of the search bar's state, so it would not only change its appearance, but also its state. Now, after clicking in an empty area, there is only needed one TAB to select the search box again, as expected.