Fix editor not saving when textbox is focused during exit procedure #26717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
reviewed
Jan 27, 2024
osu.Game.Tests/Visual/Navigation/TestSceneBeatmapEditorNavigation.cs
Outdated
Show resolved
Hide resolved
bdach
reviewed
Feb 2, 2024
osu.Game/Screens/Edit/Editor.cs
Outdated
Comment on lines
722
to
726
| // Before exiting, trigger a focus loss. | ||
| // | ||
| // This is important to ensure that if the user is still editing a textbox, it will commit | ||
| // (and potentially block the exit procedure for save). | ||
| GetContainingInputManager().TriggerFocusContention(this); |
There was a problem hiding this comment.
I'm having a hard time accepting this workaround all the way up here in Editor. Can we at least add a virtual method like EditorScreen.OnExiting() and move this there? That way at least the bodge would be isolated to the screen.
There was a problem hiding this comment.
I've applied this unilaterally in 807d982 to necro this.
bdach
previously approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26324.