Fix timing point changes not applying after selecting another one #26585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resolved by scheduling the switch in control point selection, since, at the moment that the user clicks and
RowBackground
handles the click (returning true inOnClick
), focus lost event is rolled out to any focused text box and commit calls are made.In master, control points are switched before the focus lost event is dispatched, causing the text box to commit to the new control point rather than the previously selected one.
By scheduling, focus lost events are dispatched first, then the control point is switched in the next frame.
Before:
CleanShot.2024-01-17.at.08.41.40.mp4
After:
CleanShot.2024-01-17.at.08.39.33.mp4