Fade hold-for-menu button out completely on non-touch devices #26542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Jan 16, 2024
| text.FadeInFromZero(500, Easing.OutQuint).Delay(1500).FadeOut(500, Easing.OutQuint); | ||
| touchActive = sessionStatics.GetBindable<bool>(Static.TouchInputActive); | ||
|
|
||
| if (touchActive.Value) |
There was a problem hiding this comment.
Is this intentionally checked only once ever?
It's a bit weird for me to first take out a config bindable to then only check it once...
There was a problem hiding this comment.
It's used in Update as well, to get the minimum alpha level. This one is just to decide how to animate, and there's not much point in checking beyond the initial load.
bdach
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #26128.
Addresses https://discord.com/channels/188630481301012481/188630652340404224/1187604735574954014
I re-PR'd this because the other attempt is a bit incorrect and fixing would be higher effort.