Fix crash when clicking osu! logo in song select immediately after exiting

[bdach]

Closes #26415.

The crash report with incomplete log was backwards, the exit comes first. Sentry events and the reproducing test in 8a87301 confirm this.

[Joehuu]

Similar thing happens on multiplayer/playlists:

[runtime] 2024-01-09 00:21:52 [error]: An unhandled error has occurred.
[runtime] 2024-01-09 00:21:52 [error]: osu.Framework.Screens.ScreenStack+ScreenNotCurrentException: Cannot perform Exit on a non-current screen.
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Screens.ScreenStack.Exit(IScreen source)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Screens.ScreenExtensions.Exit(IScreen screen)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Game.Screens.OnlinePlay.Multiplayer.MultiplayerMatchSongSelect.SelectItem(PlaylistItem item) in /Users/joseph/Documents/GitHub/osu/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSongSelect.cs:line 116
[runtime] 2024-01-09 00:21:52 [error]: at osu.Game.Screens.OnlinePlay.OnlinePlaySongSelect.OnStart() in /Users/joseph/Documents/GitHub/osu/osu.Game/Screens/OnlinePlay/OnlinePlaySongSelect.cs:line 144
[runtime] 2024-01-09 00:21:52 [error]: at osu.Game.Screens.Select.SongSelect.FinaliseSelection(BeatmapInfo beatmapInfo, RulesetInfo ruleset, Action customStartAction) in /Users/joseph/Documents/GitHub/osu/osu.Game/Screens/Select/SongSelect.cs:line 484
[runtime] 2024-01-09 00:21:52 [error]: at osu.Game.Screens.Select.SongSelect.<LogoArriving>b__104_0() in /Users/joseph/Documents/GitHub/osu/osu.Game/Screens/Select/SongSelect.cs:line 663
[runtime] 2024-01-09 00:21:52 [error]: at osu.Game.Screens.Menu.OsuLogo.OnClick(ClickEvent e) in /Users/joseph/Documents/GitHub/osu/osu.Game/Screens/Menu/OsuLogo.cs:line 395
[runtime] 2024-01-09 00:21:52 [error]: at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.ButtonEventManager`1.PropagateButtonEvent(IEnumerable`1 drawables, UIEvent e)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.MouseButtonEventManager.handleClick(InputState state, List`1 targets)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.MouseButtonEventManager.HandleButtonUp(InputState state, List`1 targets)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.ButtonEventManager`1.handleButtonUp(InputState state)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.InputManager.HandleMouseButtonStateChange(ButtonStateChangeEvent`1 e)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.UserInputManager.HandleInputStateChange(InputStateChangeEvent inputStateChange)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.StateChanges.ButtonInput`1.Apply(InputState state, IInputStateChangeHandler handler)
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.InputManager.Update()
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Input.PassThroughInputManager.Update()
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Platform.GameHost.UpdateFrame()
[runtime] 2024-01-09 00:21:52 [error]: at osu.Framework.Threading.GameThread.processFrame()
[runtime] 2024-01-09 00:21:52 [verbose]: Unhandled exception has been denied .

[peppy]

Based on this happening in more places, it almost feels like the call of OnStart should be checked rather than handling in each overridden implementation.. maybe in FinaliseSelection? Should we ever be finalising when the screen isn't currently?