Disable pausing music during intro sequence #26411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
changed the title
bdach
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25999
This disables the track playback from being controlled when the intro sequence begins, and allows control to the user again when the main menu appears.
Previously the intro sequence music was able to be paused, and after would suddenly resume to the one of the intro tracks or a beatmap track suddenly.
Before:
intro-paused-before.mp4
After:
intro-pausing-after.mp4
Just a heads up... The test does it's job, but I'm not 100% confident in the code quality of the test. I've tried my best and did digging around with other tests for understanding, but got a little lost when it seemed like I should use
OsuGameTestScenebut needed an input during it's intro sequence.So I'm ready to learn if I wrote the test poorly. 👍