Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popup dialog design #26187

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 28, 2023


Had to be done. I got irked every time these came up.

As usual, disclaimer that this is an iterative design and will probably be replaced in the future.

CleanShot.2023-12-28.at.10.16.03.mp4

Had to be done. I hated the old ones so much.

As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Dec 28, 2023
@bdach
Copy link
Collaborator

bdach commented Dec 28, 2023

May want to put some side padding on the popup text content:

osu_2023-12-28_11-38-09
osu_2023-12-28_11-39-04

@peppy peppy merged commit 1de3e37 into ppy:master Dec 28, 2023
10 of 11 checks passed
@peppy peppy deleted the dialog-overlay-design-update branch January 4, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L type:cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants