Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mania PERFECT back to giving bonus, just smaller #26139

Closed
wants to merge 1 commit into from

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Dec 26, 2023

I have not tested this at all. PRing early so I can do a diffcalc comparison.

In theory, this would allow us to preserve 100% == SS, while not impacting the ordering of scores in much of a noticeable impact (4k vs 200k previously, on a 4000 note map).

This is mostly a revert of #25945, with a few changes.

@smoogipoo
Copy link
Contributor Author

!diffcalc

RULESET=mania
GENERATORS=score

Copy link

github-actions bot commented Dec 26, 2023

Target: #26139
Spreadsheet:

@bdach
Copy link
Collaborator

bdach commented Dec 26, 2023

what about the arguments that score should never exceed 1 million? there were a fair few of those.

@smoogipoo
Copy link
Contributor Author

smoogipoo commented Dec 26, 2023

I'm hoping that this is more acceptable as not breaking the "sanctity" of 1M, due to the much smaller bonus. I'll see how the spreadsheet looks first, and then post a discussion on Discord to gather others' opinions.

@peppy
Copy link
Member

peppy commented Dec 26, 2023

I'd also still like to split out the bonus portion for display purposes. Both on leaderboards and the results screen...

@smoogipoo
Copy link
Contributor Author

Dropping this for now.

@smoogipoo smoogipoo closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants