-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rewind incorrectly selecting the same beatmap #26127
Conversation
Please add test coverage (ie. add a test which fails without your change) somewhere around here: osu/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs Lines 417 to 474 in b884f1a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs test
Added a working test, although I wasn't sure how to populate |
Test fails on master, so it'll work. |
@ntransw no need to merge master. please read contributing guidelines. now i have to re-approve the CI run that i was gonna see if it passes. |
Fixes #25904