Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate numeric HitResult values, add accuracy conversion #25993

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Relocate numeric HitResult values, add accuracy conversion #25993

merged 4 commits into from
Dec 21, 2023

Conversation

smoogipoo
Copy link
Contributor

  • Judgement.NumericResultFor()/Judgement.ToNumericResult() et al. have been removed.
  • ScoreProcessor. GetNumericResultFor()/ScoreProcessor.GetMaxNumericResultFor() removed.
  • virtual ScoreProcessor.GetBaseScoreForResult(HitResult) added as the new method to retrieve the raw scoring values.
  • StandardisedScoreMigrationTools.ConvertFromLegacyTotalScore() made private.
  • StandardisedScoreMigrationTools.UpdateFromLegacy() added, which converts totalscore and (now) accuracy.
    • This is something that was previously being done manually inside the highscore importer, but the in-client import didn't do this which felt inconsistent.

@smoogipoo smoogipoo mentioned this pull request Dec 21, 2023
Merged
1 task
@smoogipoo
Copy link
Contributor Author

!diffcalc

GENERATORS=score
RULESET=taiko
SCORE_PROCESSOR_B=ppy/osu-queue-score-statistics#189

@smoogipoo
Copy link
Contributor Author

!diffcalc

GENERATORS=score
RULESET=osu
SCORE_PROCESSOR_B=ppy/osu-queue-score-statistics#189

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

Target: #25993
Spreadsheet: https://docs.google.com/spreadsheets/d/1jLM9qCYFLUOiuI5LSDa7BvMlhvOeQM8JM9_o9ZKVSyk/edit

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

Target: #25993
Spreadsheet: https://docs.google.com/spreadsheets/d/11iG4CPg6i8_Zfz3lMGZ1GIl8pfgnO_Czs5GoPjW8zSg/edit

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Dec 21, 2023
@bdach
Copy link
Collaborator

bdach commented Dec 21, 2023

Source looks generally good, but I do want to do some follow-up tests here still.

bdach
bdach approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@bdach bdach merged commit 7e9d12e into ppy:master Dec 21, 2023
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:scoring next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoogipoo @bdach @peppy