New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate MaxCombo scoring attrib for non-osu rulesets #25808

Merged

peppy merged 1 commit into ppy:master from smoogipoo:fix-scoring-attribs-maxcombo

Dec 18, 2023

Contributor

smoogipoo commented Dec 18, 2023 •

edited

Loading

Was told of this IRL, though it isn't actually used anywhere during conversion for any ruleset other than osu!.


          Populate MaxCombo scoring attrib for non-osu rulesets

smoogipoo added the area:scoring label

pull-request-size bot added the size/XS label

peppy approved these changes

View reviewed changes

peppy merged commit 92c33f2 into ppy:master

8 of 11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:scoring size/XS